-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new release] ppx_deriving (6.0.0) #25675
Conversation
CHANGES: * Fix a bug in `[@@deriving make]` that caused errors when it was used on a set of type declarations containing at least one non record type. ocaml-ppx/ppx_deriving#281 (@NathanReb) * Embed errors instead of raising exceptions when generating code with `ppx_deriving.make` ocaml-ppx/ppx_deriving#281 (@NathanReb) * Remove `[%derive.iter ...]`, `[%derive.map ...]` and `[%derive.fold ...]` extensions ocaml-ppx/ppx_deriving#278 (Simmo Saan) * Port standard plugins to ppxlib registration and attributes ocaml-ppx/ppx_deriving#263 (Simmo Saan) * Optimize forwarding in eq and ord plugins ocaml-ppx/ppx_deriving#252 (Simmo Saan) * Delegate quoter to ppxlib ocaml-ppx/ppx_deriving#263 (Simmo Saan) * Introduce `Ppx_deriving_runtime.Stdlib` with OCaml >= 4.07. This module already exists in OCaml < 4.07 but was missing otherwise. ocaml-ppx/ppx_deriving#258 (Kate Deplaix)
Most CI errors seem to be related to ocaml-ppx/ppx_deriving#279 (which isn't in the changelog):
Maybe existing versions of it need an upper bound on ppx_deriving now. A new version of ppx_deriving_yojson including ocaml-ppx/ppx_deriving_yojson#153 is probably needed. |
It looks to me like this errors are side effects of this change indeed but come from the fact that those package use The fix is likely to add that dependency to |
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
Okay this is more complicated than I thought. While removing result we seem to have messed up Since we removed an overriden |
We could either add an upper bound on ppx_deriving in ppx_deriving_yojson or simply fix this small part of the change in ppx_deriving. Given both |
I'm closing once again, will release 6.0.1 with the fix to |
Type-driven code generation for OCaml
CHANGES:
Fix a bug in
[@@deriving make]
that caused errors when it was used on a setof type declarations containing at least one non record type.
Fix a bug with [@@deriving make] on type declarations sets ocaml-ppx/ppx_deriving#281
(@NathanReb)
Embed errors instead of raising exceptions when generating code
with
ppx_deriving.make
Fix a bug with [@@deriving make] on type declarations sets ocaml-ppx/ppx_deriving#281
(@NathanReb)
Remove
[%derive.iter ...]
,[%derive.map ...]
and[%derive.fold ...]
extensions
Remove extensions from fold, iter and map plugins ocaml-ppx/ppx_deriving#278
(Simmo Saan)
Port standard plugins to ppxlib registration and attributes
Port standard plugins to ppxlib registration and attributes ocaml-ppx/ppx_deriving#263
(Simmo Saan)
Optimize forwarding in eq and ord plugins
Optimize forwarding in eq and ord plugins ocaml-ppx/ppx_deriving#252
(Simmo Saan)
Delegate quoter to ppxlib
Port standard plugins to ppxlib registration and attributes ocaml-ppx/ppx_deriving#263
(Simmo Saan)
Introduce
Ppx_deriving_runtime.Stdlib
with OCaml >= 4.07.This module already exists in OCaml < 4.07 but was missing otherwise.
Add OCaml 5.00 support to the tests and update documentation ocaml-ppx/ppx_deriving#258
(Kate Deplaix)