Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[update] melange-numeral, remove unused dep #24664

Merged
merged 1 commit into from
Oct 24, 2023
Merged

[update] melange-numeral, remove unused dep #24664

merged 1 commit into from
Oct 24, 2023

Conversation

jchavarri
Copy link
Contributor

Turns out this package is not using this dep, thanks @haochenx for pointing it out in #24656 (comment).

@jchavarri jchavarri mentioned this pull request Oct 23, 2023
Merged
@jchavarri jchavarri changed the title [update] melange-moment, remove unused dep [update] melange-numeral, remove unused dep Oct 23, 2023
haochenx
haochenx approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@haochenx haochenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me!

@avsm avsm merged commit 4cbbb77 into ocaml:master Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haochenx haochenx haochenx approved these changes

Assignees
No one assigned
Labels
consider for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jchavarri @haochenx @avsm