Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] lwt_eio (0.5) #24335

Merged
merged 1 commit into from
Aug 30, 2023
Merged

[new release] lwt_eio (0.5) #24335

merged 1 commit into from
Aug 30, 2023

Conversation

talex5
Copy link
Contributor

@talex5 talex5 commented Aug 30, 2023

Run Lwt code within Eio

CHANGES:

CHANGES:

- Add debug mode (@talex5 ocaml-multicore/lwt_eio#24).
  Passing `Lwt_eio.with_event_loop ~debug:true` enables a new debug mode,
  which detects attempts to perform effects from Lwt code.

- Update to Eio 0.12 (@talex5 ocaml-multicore/lwt_eio#23).
@avsm
Copy link
Member

avsm commented Aug 30, 2023

An s390x failure (bytecode only?) on OCaml 5, but I don't think is a blocker to merging...

#=== ERROR while compiling lwt_eio.0.5 ========================================#
# context              2.2.0~alpha3~dev | linux/s390x | ocaml-base-compiler.5.0.0 | pinned(https://github.com/ocaml-multicore/lwt_eio/releases/download/v0.5/lwt_eio-0.5.tbz)
# path                 ~/.opam/5.0/.opam-switch/build/lwt_eio.0.5
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p lwt_eio -j 3 @install @runtest
# exit-code            1
# env-file             ~/.opam/log/lwt_eio-7-f2c7c2.env
# output-file          ~/.opam/log/lwt_eio-7-f2c7c2.out
### output ###
# File "test/dune", line 1, characters 0-87:
# 1 | (mdx
# 2 |   (deps
# 3 |     (env_var "EIO_BACKEND")
# 4 |     (package lwt_eio)
# 5 |     (package eio_main)))
# (cd _build/default/test && ./mdx_gen.bc test.md) > _build/default/test/.mdx/test.md.corrected
# Command exited with code 2.

- File "test/dune", line 1, characters 0-87:
- 1 | (mdx
- 2 |   (deps
- 3 |     (env_var "EIO_BACKEND")
- 4 |     (package lwt_eio)
- 5 |     (package eio_main)))
- (cd _build/default/test && ./mdx_gen.bc test.md) > _build/default/test/.mdx/test.md.corrected
- Command exited with code 2.


<><> Error report <><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><>

@talex5
Copy link
Contributor Author

talex5 commented Aug 30, 2023

Odd. s390x is passing with ocaml-ci. The message doesn't indicate what went wrong, and it passed on rebuild.

@avsm avsm merged commit 7dbbdf3 into ocaml:master Aug 30, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants