Fix various Windows depends/available fields
#23946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
os-family = "windows" for both Cygwin and native Windows.
eio_luv should be selected at the same version.
|
Looks right to me; will just wait a tiny bit for upstream projects to react. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opam running on Cygwin has
os = "cygwin"andos-family = "windows"; opam running on native Windows itself hasos = "win32"andos-family = "windows". Usingos-family = "windows"is normally a mistake. Cygwin is an implementation of Posix on top of Windows, so on the rare occasions that something is actually common between the two (e.g..dllextension for shared objects), I think it's actually better to be more explicit and have(os = "win32" | os = "cygwin").Both submitted upstream in ocaml-multicore/eio#557 and UnixJunkie/parany#75.