Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] conduit-mirage (2.2.0) #16425

Merged
merged 3 commits into from
May 13, 2020

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented May 12, 2020

CHANGES:

* conduit-mirage adapt to dns-client 4.5.0 (mirage/ocaml-conduit#314 @hannesm)
@hannesm hannesm mentioned this pull request May 12, 2020
@camelus
Copy link
Contributor

camelus commented May 12, 2020

Commit: e23546d

A pull request by opam-seasoned @hannesm.

☀️ All lint checks passed e23546d
  • These packages passed lint tests: conduit-mirage.2.2.0, git-mirage.2.1.2, pgx_lwt_mirage.1.0

☀️ Installability check (+1)
  • new installable packages (1): conduit-mirage.2.2.0

…hey generate code which won't work with conduit-mirage 2.2.0
@hannesm
Copy link
Member Author

hannesm commented May 13, 2020

I added a conflict with existing mirage packages, since this will otherwise fail. The mirage package hardcodes the functor parameters for conduit, which have changed in this release. An upcoming mirage release will make use of this conduit-mirage package.

@kit-ty-kate
Copy link
Member

Thanks a lot!

@kit-ty-kate kit-ty-kate merged commit 9e38558 into ocaml:master May 13, 2020
@hannesm hannesm deleted the release-conduit-mirage-2.2.0 branch June 23, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants