[new release] owl-base, owl, owl-zoo and owl-top (0.7.1) #15408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES: * Add unsafe network save (owlbarn/owl#429) * Sketch Count-Min and Heavy-Hitters * Various ugfixes * Owl_io.marshal_to_file: use to_channel * Do not create .owl folder when loading owl library * Re-design of exceptions and replace asserts with verify * Add OWL_DISABLE_LAPACKE_LINKING_FLAG * Reorganise Algodiff module * Add parameter support to Zoo * Two new features in algodiff: eye and linsolve (triangular option) + improved stability of qr and chol * Implemented solve triangular * Added linsolve and lq reverse-mode differentiation * Fix build on archlinux (pkg-config cblas) * Add median and sort along in ndarray * Improve stability of lyapunov gradient tests
|
The link time issues in ubuntu and debian unstable are unfortunately expected |
kit-ty-kate
reviewed
Nov 27, 2019
| "ocaml" {>= "4.06.0"} | ||
| "dune" {>= "1.7.0"} | ||
| "ocaml-compiler-libs" | ||
| "owl" {>= version} |
There was a problem hiding this comment.
Suggested change
| "owl" {>= version} | |
| "owl" {= version} |
Wouldn't it be more error prone to use = instead of >=? (same for the other sub-packages)
|
These packages use a microscopic stable part of the API, in fact we could use >= 0.4 and it would still be fine. We use the version lower bound to be over zealous. It may be worth doing it for owl-base but the api is only growing, not expected to shrink |
|
I have added the constraint to owl wrt owl-base. I’ll do the same upstream |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCaml Scientific and Engineering Computing - Base
CHANGES: