ppx_deriving.4.4, with 4.08 support #14454

gasche · 2019-07-08T12:38:36Z

Restore support for OCaml 4.02.3
4.02 nit in the tests ocaml-ppx/ppx_deriving#188
(ELLIOTTCABLE)
workaround Location.input_filename being empty
when using reason-language-server
Support empty Location.input_name in input ast ocaml-ppx/ppx_deriving#196
(Ryan Artecona)
Add support for OCaml 4.08.0
4.08 support ocaml-ppx/ppx_deriving#193, Add Result.result to the .mli file ocaml-ppx/ppx_deriving#197, Result: ensure Result.t and Result.result are exposed under both 4.08 and earlier versions ocaml-ppx/ppx_deriving#200
(Gabriel Scherer)

camelus · 2019-07-08T13:40:40Z

🌤️ opam-lint warnings `587c1be`

ppx_deriving_rpc.5.9.0 has some warnings:
- warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
visitors.20171124 has some warnings:
- warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
visitors.20180306 has some warnings:
- warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
visitors.20180513 has some warnings:
- warning 47: Synopsis (or description first line) should start with a capital and not end with a dot
These packages passed lint tests: js_of_ocaml-ppx_deriving_json.3.1.0, js_of_ocaml-ppx_deriving_json.3.2.0, js_of_ocaml-ppx_deriving_json.3.3.0, nocrypto.0.5.4-1, ppx_deriving.4.4, ppx_deriving_argparse.0.0.4, ppx_deriving_argparse.0.0.5, ppx_deriving_protobuf.2.6, ppx_deriving_yojson.3.3, ppx_deriving_yojson.3.4

☀️ Installability check (+1)

new installable packages (1): ppx_deriving.4.4

gasche · 2019-07-08T14:12:56Z

The revdeps look good (there are few 4.08-available dependencies to test, but some like lens are and they seem to work), so I'll cut a real release and un-draft this PR.

kit-ty-kate · 2019-07-08T16:37:43Z

Once OCaml 4.08 enabled there was a lot of revdeps failures. I fixed most of them but this one seems rather weird:

#=== ERROR while compiling nocrypto.0.5.4-1 ===================================#
# context              2.0.4 | linux/x86_64 | ocaml-base-compiler.4.08.0 | git+file:///home/opam/opam-repository
# path                 ~/.opam/4.08/.opam-switch/build/nocrypto.0.5.4-1
# command              ~/.opam/4.08/bin/ocaml pkg/pkg.ml build --pinned false --tests false --jobs 1 --with-lwt true --xen false --freestanding false
# exit-code            1
# env-file             ~/.opam/log/nocrypto-17-c7ac5d.env
# output-file          ~/.opam/log/nocrypto-17-c7ac5d.out
### output ###
[...]
# + ocamlfind ocamlopt -pack -g -bin-annot -package ppx_sexp_conv -package bytes -package sexplib -package cstruct -I src src/native.cmx src/uncommon.cmx src/base64.cmx src/hash.cmx src/cipher_stream.cmx src/ccm.cmx src/numeric.cmx src/gcm.cmx src/cipher_block.cmx src/fortuna.cmx src/hmac_drgb.cmx src/rng.cmx src/rsa.cmx src/dsa.cmx src/dh.cmx -o src/nocrypto.cmx
# Fatal error: exception Invalid_argument("index out of bounds")
# Command exited with code 2.

There are a few broken packages to deal with but let's leave it like that for today

mseri · 2019-07-08T17:41:08Z

That's quite interesting, in principle it should not depend on ppx_deriving but just on ppxlib, right?

gasche · 2019-07-08T19:33:35Z

@kit-ty-kate thanks! I think that the failure that you are seeing on nocrypto is a 4.08.0 compiler bug that we have fixed in the 4.08 branch upstream, ocaml/ocaml#8770

gasche · 2019-07-09T12:43:13Z

I studied more revdeps failures, and I didn't find anything very suspicious. (ppx_deriving_argparse is failing because of a hardcoded .cmxs path that changed when we moved to a Dune build, I can send a fix upstream and ask for a new release.) There are some unrelated failures and some plugins that really need a 4.08 upgrade.

I will complete the release and rebase this PR to point to the definitive archive. Thanks again @kit-ty-kate for the work triaging the issues and marking 4.08 incompatibility in dependent packages.

gasche · 2019-07-09T12:47:04Z

Ahem. I force-pushed to my github clone out of habit, and lost the extra commits that @kit-ty-kate had pushed. Apologies... @kit-ty-kate, can I find them in your own github fork? (I just looked but I don't see the branch.)

gasche · 2019-07-09T12:49:55Z

(No worries, I just got the missing patches from github: https://github.com/ocaml/opam-repository/compare/6506d59227c0380f861d6a647558cecb87673f55..8be19ff9ffa3517d2d749d13a847e589536bdfcc.patch )

…OCaml >= 4.08

kit-ty-kate · 2019-07-09T12:52:42Z

I had them locally. It was pushed on your branch directly. You might want to use git push --force-with-lease by default, it's very handy

ppx_deriving.4.3 installs each plugin in a separate subdirectory, which breaks the hardcoded paths in the build system of the "make test" rule of ppx_deriving_argparse.

kit-ty-kate · 2019-07-09T12:55:17Z

oops sorry my bad, I thought there was a mistake

gasche · 2019-07-09T12:56:10Z

Wow, --force-with-lease sounds very handy, thanks! (I wonder if there is a way to make it the default --force behavior.)

I just pushed an updated version of the branch that should be final (CI can always tell otherwise). I restricted the package to (< 4.09), so that we avoid use-side build failures in the future. I restricted ppx_deriving_argparse to 4.3 instead of 4.4 (the failure is not new).

kit-ty-kate · 2019-07-09T13:00:30Z

I restricted ppx_deriving_argparse to 4.3 instead of 4.4 (the failure is not new).

Are you sure? check.ocamllabs.io tells me otherwise: http://check.ocamllabs.io/log/1562505242-7152ba482366e28003d2457509dd618295bc655d/4.07.1/good/ppx_deriving_argparse.0.0.4 (but that's not really important anyway)

gasche · 2019-07-09T13:01:50Z

The failure is only in the make test rule, but I thought I reproduced it locally under 4.3 and 4.07. Let me try again.

gasche · 2019-07-09T13:02:26Z

+ ocamlfind ocamlc -c -g -bin-annot -safe-string -ppx 'ocamlfind ppx_deriving/ppx_deriving src/ppx_deriving_argparse.cma /home/gasche/.opam/4.07.1/lib/ppx_deriving/ppx_deriving_show.cma' -I /home/gasche/.opam/4.07.1/lib/ppx_deriving/ -package result -package oUnit -w @5@8@10@11@12@14@23@24@26@29@40 -I src_test -I src -o src_test/test.cmo src_test/test.ml
File "_none_", line 1:
Error: Cannot load /home/gasche/.opam/4.07.1/lib/ppx_deriving/ppx_deriving_show.cmxs: cannot find file /home/gasche/.opam/4.07.1/lib/ppx_deriving/ppx_deriving_show.cmxs in search path

kit-ty-kate · 2019-07-09T15:00:58Z

thanks a lot!

kit-ty-kate · 2019-07-09T17:01:11Z

Ping to maintainers of packages of which latest version is not available with OCaml 4.08:

@masashi-y for ppx_deriving_argparse
@gasche for ppx_deriving_protobuf and ppx_deriving_yojson
@samoht for ppx_deriving_rpc
@fpottier for visitors

fpottier · 2019-07-10T06:36:15Z

Well, someone (@kit-ty-kate or @gasche?) marked visitors as incompatible with 4.08, without telling me. Would you care to explain what the problem is? Is it a problem with my code, or with some package that visitors depends upon, maybe ppx_deriving or ppx_tools?

gasche · 2019-07-10T06:48:21Z

That's part of the maintenance operations that we (most of that work is done by @kit-ty-kate) perform when the build of a package breaks (the idea is to mark it incompatible as soon as possible to avoid end-users seeing build failures). You were just "told" by the cc above: -- done by @kit-ty-kate when the change to the visitors description was merged in the main repository.

Here is what I get if I try to build visitors on 4.08:

+ ocamlfind ocamlc -c -g -safe-string -package compiler-libs.common -package ppx_deriving.api -w A-4-44 -package result -o VisitorsCompatibility.cmo VisitorsCompatibility.ml
File "VisitorsCompatibility.cppo.ml", line 128, characters 6-21:
Error: The constructor Otag expects 2 argument(s),
       but is applied here to 3 argument(s)

XVilka mentioned this pull request Jul 8, 2019

ppx_deriving : cannot install on 4.08.0 #14436

Closed

gasche mentioned this pull request Jul 8, 2019

release 4.4 with 4.08 support ocaml-ppx/ppx_deriving#201

Merged

XVilka mentioned this pull request Jul 9, 2019

dune/jbuilder support unreleased? ocaml-ppx/ppx_deriving_protobuf#23

Closed

gasche force-pushed the ppx_deriving.4.4 branch from 8be19ff to 78f53e0 Compare July 9, 2019 12:44

gasche and others added 2 commits July 9, 2019 14:51

release ppx_deriving.4.4

707231b

Mark various reverse dependency of ppx_deriving as incompatible with …

e8fb66e

…OCaml >= 4.08

gasche force-pushed the ppx_deriving.4.4 branch from fac68a7 to 49f96c0 Compare July 9, 2019 12:53

kit-ty-kate added 2 commits July 9, 2019 14:53

ppx_deriving_argparse is incompatible with ppx_deriving >= 4.3

40ffcb9

ppx_deriving.4.3 installs each plugin in a separate subdirectory, which breaks the hardcoded paths in the build system of the "make test" rule of ppx_deriving_argparse.

nocrypto.0.5.4-1 triggers a compiler bug in OCaml 4.08.0

49f96c0

kit-ty-kate force-pushed the ppx_deriving.4.4 branch from 49f96c0 to fac68a7 Compare July 9, 2019 12:54

gasche force-pushed the ppx_deriving.4.4 branch from fac68a7 to 49f96c0 Compare July 9, 2019 12:55

gasche marked this pull request as ready for review July 9, 2019 12:56

ppx_deriving_argparse: put more precise constraints

587c1be

kit-ty-kate merged commit 36df785 into ocaml:master Jul 9, 2019

gasche changed the title ~~[WIP] ppx_deriving.4.4 release preparation branch~~ ppx_deriving.4.4, with 4.08 support Jul 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ppx_deriving.4.4, with 4.08 support #14454

ppx_deriving.4.4, with 4.08 support #14454

gasche commented Jul 8, 2019

camelus commented Jul 8, 2019 •

edited

Loading

gasche commented Jul 8, 2019

kit-ty-kate commented Jul 8, 2019

mseri commented Jul 8, 2019

gasche commented Jul 8, 2019

gasche commented Jul 9, 2019

gasche commented Jul 9, 2019

gasche commented Jul 9, 2019

kit-ty-kate commented Jul 9, 2019

kit-ty-kate commented Jul 9, 2019 •

edited

Loading

gasche commented Jul 9, 2019

kit-ty-kate commented Jul 9, 2019

gasche commented Jul 9, 2019

gasche commented Jul 9, 2019

kit-ty-kate commented Jul 9, 2019

kit-ty-kate commented Jul 9, 2019

fpottier commented Jul 10, 2019 •

edited

Loading

gasche commented Jul 10, 2019

ppx_deriving.4.4, with 4.08 support #14454

ppx_deriving.4.4, with 4.08 support #14454

Conversation

gasche commented Jul 8, 2019

camelus commented Jul 8, 2019 • edited Loading

🌤️ opam-lint warnings 587c1be

☀️ Installability check (+1)

gasche commented Jul 8, 2019

kit-ty-kate commented Jul 8, 2019

mseri commented Jul 8, 2019

gasche commented Jul 8, 2019

gasche commented Jul 9, 2019

gasche commented Jul 9, 2019

gasche commented Jul 9, 2019

kit-ty-kate commented Jul 9, 2019

kit-ty-kate commented Jul 9, 2019 • edited Loading

gasche commented Jul 9, 2019

kit-ty-kate commented Jul 9, 2019

gasche commented Jul 9, 2019

gasche commented Jul 9, 2019

kit-ty-kate commented Jul 9, 2019

kit-ty-kate commented Jul 9, 2019

fpottier commented Jul 10, 2019 • edited Loading

gasche commented Jul 10, 2019

camelus commented Jul 8, 2019 •

edited

Loading

🌤️ opam-lint warnings `587c1be`

kit-ty-kate commented Jul 9, 2019 •

edited

Loading

fpottier commented Jul 10, 2019 •

edited

Loading