Constrain packages not available on ARM64 #11768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
force-pushed
the
arm64-const
branch
2 times, most recently
from
482ce8d to
e2d4846
Compare
✅ All lint checks passed dad41b5
✅ Installability check (8682 → 8682) |
|
Don't merge this PR yet. We are trying to figure out what is supposed to work (see the comment on the ocaml-freestanding issue) |
|
cc @AltGr |
mato
reviewed
Apr 13, 2018
| @@ -20,6 +20,6 @@ conflicts: [ | |||
| ] | |||
| available: [ | |||
| ocaml-version >= "4.02.3" & ocaml-version < "4.07.0" & | |||
| ((os = "linux" & (arch = "x86_64" | arch = "aarch64")) | | |||
| ((os = "linux" & (arch = "x86_64" | arch = "arm64")) | | |||
There was a problem hiding this comment.
@kit-ty-kate Based on the discussion in mirage/ocaml-solo5#36, this doesn't seem right. ocaml-freestanding does work on Linux/aarch64, won't this break users trying to install it with OPAM 1 where arch will be aarch64?
There was a problem hiding this comment.
Yes yes, I haven't made the change yet. I'll do today.
There was a problem hiding this comment.
By change I mean "don't change anything"
kit-ty-kate
force-pushed
the
arm64-const
branch
from
e2d4846 to
dad41b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported here for
core: janestreet/core#110Reported upstream for
ocaml-freestanding: mirage/ocaml-solo5#36