Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocaml-basics: upper bound on ppx_deriving #10149

Closed
wants to merge 1 commit into from
Closed

ocaml-basics: upper bound on ppx_deriving #10149

wants to merge 1 commit into from

Conversation

avsm
Copy link
Member

@avsm avsm commented Aug 23, 2017

newer ppx_deriving errors on local exceptions

noted in revdeps for #10136

the error is odd since it is in fact running on ocaml 4.04.2

# File "lib/OBMap.ml", line 33, characters 2-228: local exceptions are not supported before OCaml 4.04
# File "lib/OBMap.ml", line 1:
# Error: Error while running external preprocessor
# Command line: /home/opam/.opam/ocaml-base-compiler.4.04.2/lib/ppx_deriving/./ppx_deriving package:ppx_sexp_conv '/tmp/camlppxaf81bb' '/tmp/camlppxeb974b'
# 
# Command exited with code 2.
# E: Failure("Command ''/home/opam/.opam/ocaml-base-compiler.4.04.2/bin/ocamlbuild' lib/basics.cma lib/basics.cmxa lib/basics.a lib/basics.cmxs -tag debug' terminated with error code 10")

@camelus
Copy link
Contributor

camelus commented Aug 23, 2017

✅ All lint checks passed 303652d
  • These packages passed lint tests: ocaml-basics.0.3.0, ocaml-basics.0.4.0

✅ Installability check (7446 → 7446)

@samoht
Copy link
Member

samoht commented Sep 7, 2017

Errors are due to download errrors, so I've restarted the failing jobs.

newer ppx_deriving errors on local exceptions
@samoht
Copy link
Member

samoht commented Sep 13, 2017

I've rebased your PR to the current master

@samoht
Copy link
Member

samoht commented Sep 21, 2017

Superseeded by #10265

@samoht samoht closed this Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants