Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spec 353: ASCII character 160, non-breaking space, is white space #247

Merged
merged 3 commits into from
May 30, 2021

Conversation

shonfeder
Copy link
Collaborator

Fixes failing verification of spec unit 353. See 2441975 for details.

Turned up while refactoring issue #235 into smaller work items.

This PR also adds make targets to streamline regeneration of tests and

The generation of tests wasn't documented. This documents it and scripts
it.
The spec requires the nonbreaking whitespace character, ASCII code 160
to be recognized as white space.

https://en.wikipedia.org/wiki/Non-breaking_space
@shonfeder shonfeder changed the title /fix spec 353 Fix spec 353 May 29, 2021
@shonfeder shonfeder requested a review from sonologico May 29, 2021 18:10
@shonfeder shonfeder changed the title Fix spec 353 Fix spec 353: ASCII character 160, non-breaking space, is white space May 29, 2021
Copy link
Collaborator

@sonologico sonologico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Good catch.

@shonfeder shonfeder merged commit 89cf92b into ocaml:master May 30, 2021
@shonfeder shonfeder deleted the 235/fix-spec-353 branch May 30, 2021 13:14
mseri pushed a commit to ocaml/opam-repository that referenced this pull request Jun 25, 2021
CHANGES:

- Clean up AST representation (ocaml/omd#229, @sonologico)

- Restore table of contents generation functionality (ocaml/omd#240, @sonologico)

- Fix parsing of <...>-style links and inline code parsing (ocaml/omd#233, @SquidDev)

- Fix handing of the nonbreaking whitespace character, ASCII code 160 (ocaml/omd#247,
  @shonfeder)

- Downgrade dune requirements to 2.0 (@nobj)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants