Compat with OCaml 5.3.0~alpha1 #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julow
commented
Sep 30, 2024
| @@ -9,7 +9,7 @@ and that "hidden" modules (eg. `A__b`, rendered to `html/A__b`) are not rendered | |||
| $ ocamlc -bin-annot -o a__b.cmo -c b.ml | |||
| $ ocamlc -bin-annot -o a.cmi -c a.mli | |||
| $ ocamlc -bin-annot -o a.cmo -c a.ml | |||
| $ ocamlc -bin-annot -a -o a.cma a.cmo a__b.cmo | |||
| $ ocamlc -bin-annot -a -o a.cma a__b.cmo a.cmo | |||
There was a problem hiding this comment.
The compiler caught a potential bug:
$ ocamlc -bin-annot -a -o a.cma a.cmo a__b.cmo
File "_none_", line 1:
Error: Wrong link order: A (a.cmo) depends on A__b (a__b.cmo)
[2]
jonludlam
reviewed
Sep 30, 2024
| module X' : sig type t = SubX.t end | ||
| end | ||
| module type X6 = sig type t end | ||
|
|
There was a problem hiding this comment.
Output is unstable due to the new functor syntax in module type exprs. I thought this output wasn't very interesting so I removed it.
There was a problem hiding this comment.
That's a shame - this was intended to be directly compared with the output from odoc (see https://github.com/ocaml/odoc/pull/1202/files/6119c82332b0dc5756a58fa208fd83b9b98e1108#diff-b3b2e29d50da342308f1468a32da8a0a9a40ca40c5b3c654521d8b891b38fab8R49)
There was a problem hiding this comment.
That's a shame indeed. The command can still be added temporarily again to debug the test.
Anyway, that's an automated test.
|
Thanks! |
This was referenced Oct 21, 2024
Closed
Julow
added a commit
to Julow/opam-repository
that referenced
this pull request
Dec 5, 2024
CHANGES: ### Added - OCaml 5.3.0 compatibility (@Julow, ocaml/odoc#1202, ocaml/odoc#1254)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.