Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MSVC testing #347

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Add MSVC testing #347

merged 5 commits into from
Jun 26, 2024

Conversation

dra27
Copy link
Member

@dra27 dra27 commented Jun 25, 2024

Some work needed on the testsuite, but starting to build on the truly astounding work already done on Windows support here!

Should fix #323 as we're now testing msvc

@hhugo
Copy link
Collaborator

hhugo commented Jun 25, 2024

I've pushed changes to the testsuite. CI is now happy

@hhugo
Copy link
Collaborator

hhugo commented Jun 25, 2024

One still need to properly fix conditional steps in the CI

@hhugo hhugo mentioned this pull request Jun 25, 2024
@gasche
Copy link
Member

gasche commented Jun 25, 2024

The PR as-is looks fairly clean (unlike some intermediate iterations); congratulations are due to @dra27 and @hhugo. Isn't this ready for review?

@hhugo
Copy link
Collaborator

hhugo commented Jun 25, 2024

No, I'm unhappy about the conditional step change in the ci

@hhugo hhugo marked this pull request as ready for review June 26, 2024 06:21
@hhugo
Copy link
Collaborator

hhugo commented Jun 26, 2024

@gasche, this is now ready.

@hhugo hhugo requested a review from gasche June 26, 2024 06:22
@dra27
Copy link
Member Author

dra27 commented Jun 26, 2024

Thanks, @hhugo - you got the fixes in for the testsuite before I'd had a chance to finish my version locally! Technically c664696 is not part of restoring MSVC - I don't know if you'd prefer that to be a in a separate PR?

Copy link
Member

@gasche gasche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mix of "foo" -.- bar and "foo." ^ bar in the testsuite is a bit jarring (it took me a few dozen seconds to convince myself than no, they were strictly equivalent), but maybe we can tolerate this if you find it cumbersome to cleanup, and generally the patch is nice to read. I am okay with having the commit that adds .exe to the install script as part of this PR.

@hhugo
Copy link
Collaborator

hhugo commented Jun 26, 2024

The mix of "foo" -.- bar and "foo." ^ bar in the testsuite is a bit jarring (it took me a few dozen seconds to convince myself than no, they were strictly equivalent), but maybe we can tolerate this if you find it cumbersome to cleanup, and generally the patch is nice to read. I am okay with having the commit that adds .exe to the install script as part of this PR.

fixed

@hhugo hhugo merged commit 43d86e6 into ocaml:master Jun 26, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants