Setup github actions for ocamlbuild #328
Conversation
|
also, replaces #317 |
|
|
||
| let copy l dest = | ||
| ignore(Sys.command (Printf.sprintf "mkdir -p %s" dest)); | ||
| List.iter (fun f -> ignore(Sys.command (Printf.sprintf "cp %s/%s %s" build_tree f dest))) l |
There was a problem hiding this comment.
Could you write these with Sys.command @@ Filename.quote_command ...? It is good practice to protect ourselves against spaces in the build path.
There was a problem hiding this comment.
Filename.quote_command was introduced in OCaml 4.10. I could use Filename.quote but I don't really understand the implication of its documentation
Warning: under Windows, the output is only suitable for use
with programs that follow the standard Windows quoting
conventions.
There was a problem hiding this comment.
Gasp, are we still trying to support OCaml releases older than 4.10? Okay for the current code then.
There was a problem hiding this comment.
(Debian stable has 4.13, oldstable has 4.11.)
There was a problem hiding this comment.
We probably need to bump the constraint in the opam file. It's currently 4.03, I think
|
@hhugo would you be interested in the commit bit on ocamlbuild? I am not actively maintaining it, I guess that it could benefit from some help, and you seem very dedicated. |
I can do a bit of support, you can add me. |
This PR migrate the existing travis.yml CI instructions to github-actions.
Currently testing OCaml 4.08 .. 5.2
It also includes the following fixes.
The underlying reason for the MR is to make is easier to test fixes for windows, such as #323