Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compatibility layer for newer ocaml. #78

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Added compatibility layer for newer ocaml. #78

merged 1 commit into from
Apr 21, 2020

Conversation

bschommer
Copy link
Contributor

Pervasives is deprecated since ocaml 4.08 and should be replaced
by Stdlib.

@bschommer
Copy link
Contributor Author

This fixes the bootstrap build with ocaml 4.08.1 and later.

Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay to feedback on this - it would be worth waiting until #81 is merged as CI will be back, but then if you'd be able to rebase and correct the compatibility to be for 4.07 this will be good to go, thanks!

Compat408.ml Outdated Show resolved Hide resolved
Compat408.ml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@dra27
Copy link
Member

dra27 commented Apr 20, 2020

This looks good to go, thanks - would you be able to rebase and squash just so we get a full CI run?

Pervasives is deprecated since ocaml 4.07 and should be replaced
by Stdlib.
@bschommer
Copy link
Contributor Author

I just rebased and squashed.

@dra27
Copy link
Member

dra27 commented Apr 21, 2020

Great, thanks!

@dra27 dra27 merged commit 451b17d into ocaml:master Apr 21, 2020
@bschommer bschommer deleted the compat-4.08.1 branch April 22, 2020 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants