Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out floating attributes in Pp_ast #525

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

NathanReb
Copy link
Collaborator

This will prove particularly useful for our internal use as it won't print [@@@ocaml.ppx.context] unless asked to.

Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
@NathanReb NathanReb added the no changelog Use this label to disable the changelog check github action label Sep 24, 2024
Copy link
Collaborator

@patricoferris patricoferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NathanReb ! :)

@NathanReb NathanReb merged commit 27a754c into ocaml-ppx:main Sep 25, 2024
7 checks passed
@NathanReb NathanReb mentioned this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Use this label to disable the changelog check github action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants