Revert #128 and reapply the original fix from #126 #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frama-C failed with my fix so I'm reapplying @martinslota's original fix from #126 (sorry for that)
After that I suppose this is fine to re-release 3.6.0.
Side-note: I added a few TODO comments as currently
[@default ...]
is broken when passed a value from a module also defined inPpx_deriving_runtime
(currentlyList
,String
,Bytes
,Int32
,Int64
,NativeInt
,Array
,Result
as well as several short functions and types).At best this is going to fail to compile, at worst the values/functions used are not going to have the same behaviour as expected and might enable nasty bugs.
I do not have enough knowledge of the codebase and on how to do that properly but since it was like this before I suppose this is fine to let as is for now.