Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #128 and reapply the original fix from #126 #131

Merged
merged 2 commits into from
Nov 7, 2020

Conversation

kit-ty-kate
Copy link
Collaborator

Frama-C failed with my fix so I'm reapplying @martinslota's original fix from #126 (sorry for that)

#=== ERROR while compiling frama-c.21.1 =======================================#
# context              2.0.7 | linux/x86_64 | ocaml-base-compiler.4.11.1 | file:///home/opam/opam-repository
# path                 ~/.opam/4.11/.opam-switch/build/frama-c.21.1
# command              /usr/bin/make -j72
# exit-code            2
# env-file             ~/.opam/log/frama-c-25-632471.env
# output-file          ~/.opam/log/frama-c-25-632471.out
### output ###
# File "src/plugins/markdown-report/sarif.ml", line 335, characters 30-43:
# 335 |     stack: (Stack.t [@default Stack.default]);
#                                     ^^^^^^^^^^^^^
# Error: Unbound value Stack.default

After that I suppose this is fine to re-release 3.6.0.

Side-note: I added a few TODO comments as currently [@default ...] is broken when passed a value from a module also defined in Ppx_deriving_runtime (currently List, String, Bytes, Int32, Int64, NativeInt, Array, Result as well as several short functions and types).
At best this is going to fail to compile, at worst the values/functions used are not going to have the same behaviour as expected and might enable nasty bugs.
I do not have enough knowledge of the codebase and on how to do that properly but since it was like this before I suppose this is fine to let as is for now.

@kit-ty-kate kit-ty-kate merged commit 926cf01 into ocaml-ppx:master Nov 7, 2020
@kit-ty-kate kit-ty-kate deleted the fix-default-wrap branch November 7, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant