Fix #27 - Support for OCaml 4.08

[XVilka]

No description provided.

[gasche]

Currently the 4.08 is not passing. I'll merge the 4.07 change, and then we should fix 4.08 before enabling the CI for it. (This means you might have to rebase your PR to fix the conflict with the 4.07 one, sorry.)

[XVilka]

Surely, no problem, it is trivial change anyway.

[XVilka]

Build should be restarted/retriggered now, the ppx_deriving was updated.

[gasche]

Thanks for importing the fix here. I would be happy to merge if the CI agree, and then can work on releasing a new version.

[XVilka]

@gasche it is for attr_loc, the third record field: http://caml.inria.fr/pub/docs/manual-ocaml/compilerlibref/Parsetree.html

[gasche]

I don't think that works.

# type t = { x : int; y : int; z : int };;
type t = { x : int; y : int; z : int; }
# fun { x; _; _ } -> x;;
Error: Syntax error: '}' expected
# fun { x; y = _; _ } -> x;;
- : t -> int = <fun>

In a record pattern _ ; means "ignore all the other fields", you cannot ignore fields implicitly by position.

[XVilka]

Apparently Pberr_wrong_attr {{txt; loc}; _} doesn't work:

File "ppx_deriving_protobuf.cppo.ml", line 148, characters 22-23:
# Error: Syntax error

Update: Lol, my bad, didn't notice the field names are different

[gasche]

Well I guess you also need to name the field at which the sub-record { txt; loc } occurs.

[XVilka]

This one solved, but there are more. Will continue tomorrow locally, seems no easy one-line blind fix. Sorry for the noise, thought lazy GitHub pencil edit would solve this.

[XVilka]

@gasche ok, now it is green and ready.

[XVilka]

@gasche can you please take a look? I think it is ready to be merged

[XVilka]

Is there anything that should be done to get this merged?

[gasche]

Apologies for the delay and thanks for the pings from time to time. This isn't quite ready but the high-level plan is of course to get it merged eventually, and then make a release.

[gasche]

Seems good to merge when CI agrees, thanks! (Minor comment inline.)

[XVilka]

Seems Travis is dead. You might want to restart failed jobs.

[gasche]

I restarted some jobs; note that the 4.05 failure is real:

# File "ppx_deriving_protobuf.cppo.ml", line 391, characters 10-19:
# Error: Unbound constructor Rtag_patt

[XVilka]

Ok, now everything is green, except Travis own failure on 4.05 (can be restarted).

[gasche]

Thanks! Merged.

[XVilka]

Would be nice to make a release after that.

[gasche]

(See #29 for the release-preparation thread.)