Another fix for #97: Ast_4NN.register reads and writes current AST
#99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rent AST As Gabriel Scherer explained in ocaml-ppx#97 (comment) there is two possible semantics for `Ast_4NN.register`. (1) register a 4NN-rewriter in such a way that it works on _current_ serialized ASTs (2) register a 4NN-rewriter in such a way that it works on serialized ASTs for OCaml 4NN This commit implements (1) whereas ocaml-ppx#98 implements (2).
|
As mentioned in #98, I'm going to remote these register functions. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @gasche explained in #97 (comment), there is two possible semantics for
Ast_4NN.register.(1) register a 4NN-rewriter in such a way that it works on current serialized ASTs
(2) register a 4NN-rewriter in such a way that it works on serialized ASTs for OCaml 4NN
This pull-request implements (1) whereas #98 implements (2).