Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI updates #513

Merged
merged 5 commits into from
Jan 15, 2025
Merged

CI updates #513

merged 5 commits into from
Jan 15, 2025

Conversation

jmid
Copy link
Collaborator

@jmid jmid commented Jan 14, 2025

This PR lumps 3 CI updates into one:

  • The first 2 commits removes the 5.0 workflows (and badges). After the merge of the Gc tests Add gc tests #469, 9/9 of them failed the scheduled run, creating lots of notification email noise. Rather than spending time adjusting them to accept misbehavior on 5.0, now seems a natural point to stop running them and save some CPU cycles in the process.
  • The next 2 commits removes the 5.1 musl workflow (and badge) which is failing compilation with zstd.h not found. This is a known bug and the opam 5.1.1 opam package was explicitly back-patched in Backport ocaml/ocaml#13100 to 5.1.x ocaml-variants ocaml/opam-repository#25828 to handle this error. In choosing between continuing to fail, spending time on patching in our opam-free setup, and removing the musl-workflow from 5.1, the latter seems most sane.
  • The last commit updates the gh-pages workflow to also use setup-ocaml@v3 - an oversight from Use setup-ocaml 3 for opam workflow #512

@jmid
Copy link
Collaborator Author

jmid commented Jan 15, 2025

CI summary for 91072aa

Out of 34 workflows, 1 failed with a false alarm.

@jmid jmid merged commit 155e36e into main Jan 15, 2025
33 of 34 checks passed
@jmid jmid deleted the ci-updates branch January 15, 2025 11:51
@jmid
Copy link
Collaborator Author

jmid commented Jan 15, 2025

CI summary for merge to main: all 35 workflows passed!

@jmid jmid mentioned this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant