Add run_lwt and handle cancellation #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nothing special needs to be done to run Lwt code from Eio, but having this makes it consistent with the other combinations and avoids having to remember which way is safe.
talex5
changed the title
talex5
force-pushed
the
run_lwt
branch
2 times, most recently
from
b3b472b
to
209c189
Compare
- Cancelling a `run_lwt` Fiber cancels the Lwt promise. - Cancelling a `run_eio` promise cancels the Eio fiber.
talex5
added a commit
to talex5/opam-repository
that referenced
this pull request
Jun 21, 2022
CHANGES: - Add some tests and documentation of the internals (@talex5 ocaml-multicore/lwt_eio#9). - Bridge Eio and Lwt cancellation (@talex5 ocaml-multicore/lwt_eio#8). - Cancelling a `run_lwt` Fiber cancels the Lwt promise. - Cancelling a `run_eio` promise cancels the Eio fiber. - Add `run_lwt` for consistency with `run_eio` and Async_eio (@talex5 ocaml-multicore/lwt_eio#8). - Add `Lwt_eio.Token.t` token to ensure library is initialised (@talex5 ocaml-multicore/lwt_eio#5). `with_event_loop` now passes a `Lwt_eio.Token.t` to its callback. - Update to Eio 0.2 (@talex5 ocaml-multicore/lwt_eio#4). Eio 0.2 renamed "fibre" to "fiber". This fixes the deprecation warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run_lwtwaits for an Lwt promise, and also cancels it if the Eio fiber is cancelled.run_eiocancels the Eio fiber if the Lwt promise is cancelled.