Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lwt_eio.run_lwt_in_main #20

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

talex5
Copy link
Collaborator

@talex5 talex5 commented Jul 3, 2023

This is similar to Lwt_preemptive.run_in_main, but allows other Eio fibers to run while it's waiting.

@talex5 talex5 force-pushed the run_lwt_in_main branch 2 times, most recently from 039211e to 24885e3 Compare July 5, 2023 09:13
@talex5 talex5 merged commit 69757de into ocaml-multicore:master Jul 5, 2023
1 check passed
@talex5 talex5 deleted the run_lwt_in_main branch July 5, 2023 17:02
talex5 added a commit to talex5/opam-repository that referenced this pull request Aug 23, 2023
CHANGES:

- Get Lwt and Eio to share the SIGCHLD handler (@talex5 ocaml-multicore/lwt_eio#19).
  Otherwise, Lwt replaces Eio's handler and may prevent Eio from noticing child processes finishing.

- Don't allow cancelling things after forking (@talex5 ocaml-multicore/lwt_eio#21).
  With io_uring, this will mess up the parent's ring.

- Add `Lwt_eio.run_lwt_in_main` (@talex5 ocaml-multicore/lwt_eio#20).
  This is useful if your program uses multiple Eio domains and you want to run some Lwt code from any of them.

- Fix some Eio deprecation warnings (@talex5 ocaml-multicore/lwt_eio#18).
nberth pushed a commit to nberth/opam-repository that referenced this pull request Jun 18, 2024
CHANGES:

- Get Lwt and Eio to share the SIGCHLD handler (@talex5 ocaml-multicore/lwt_eio#19).
  Otherwise, Lwt replaces Eio's handler and may prevent Eio from noticing child processes finishing.

- Don't allow cancelling things after forking (@talex5 ocaml-multicore/lwt_eio#21).
  With io_uring, this will mess up the parent's ring.

- Add `Lwt_eio.run_lwt_in_main` (@talex5 ocaml-multicore/lwt_eio#20).
  This is useful if your program uses multiple Eio domains and you want to run some Lwt code from any of them.

- Fix some Eio deprecation warnings (@talex5 ocaml-multicore/lwt_eio#18).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant