Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the old Lwt engine after finishing #16

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

talex5
Copy link
Collaborator

@talex5 talex5 commented Feb 27, 2023

Note: using ~destroy:false here is essential! Otherwise Lwt segfaults.

Reported by @tmcgilchrist - does this fix it for you?

Note: using `~destroy:false` here is essential! Otherwise Lwt segfaults.

Reported-by: Tim McGilchrist <timmcgil@gmail.com>
@talex5 talex5 added the bug Something isn't working label Feb 27, 2023
@tmcgilchrist
Copy link

Yes that fixes the issue I was seeing.

Before:

$ dune exec -- cucumber_lwt test/test_lwt_2.feature
Done: 99% (1386/1388, 2 left) (jobs: 1)I am in the given: I have a simple background
In Manip_State with no state setting foo to 12
I am in the when: I have a thing to do
I am in the then: I have done the thing
I am in the other given
In Manip_State with no state setting foo to 12
I am in the other when
I am in the other then
I am in the given: I have a simple background
In Manip_State with no state setting foo to 12
I am in the when: I have a thing to do
I am in the then: I have done the thing
14
...
14
...
14
...
Fatal error: exception Stdlib.Effect.Unhandled(Eio__core__Suspend.Suspend(_))

After:

$ dune exec -- cucumber_lwt test/test_lwt_2.feature                        
Done: 96% (1346/1388, 42 left) (jobs: 0)I am in the given: I have a simple background
In Manip_State with no state setting foo to 12
I am in the when: I have a thing to do
I am in the then: I have done the thing
I am in the other given
In Manip_State with no state setting foo to 12
I am in the other when
I am in the other then
I am in the given: I have a simple background
In Manip_State with no state setting foo to 12
I am in the when: I have a thing to do
I am in the then: I have done the thing
14
...
14
...
14
...

@talex5 talex5 merged commit cb8591c into ocaml-multicore:master Mar 28, 2023
@talex5 talex5 deleted the restore-engine branch March 28, 2023 12:25
@talex5
Copy link
Collaborator Author

talex5 commented Mar 28, 2023

Thanks for checking!

mseri pushed a commit to ocaml/opam-repository that referenced this pull request May 15, 2023
CHANGES:

- Restore the old Lwt engine after finishing (@talex5 ocaml-multicore/lwt_eio#16, reported by @tmcgilchrist).

- Use `run_lwt` in documentation (@talex5 ocaml-multicore/lwt_eio#13).

- Update for Eio deprecations (@talex5 ocaml-multicore/lwt_eio#12 ocaml-multicore/lwt_eio#14).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants