-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Executor_pool docs #650
Executor_pool docs #650
Conversation
b5763bf
to
9ff0a3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SGrondin! This is great. I've left some comments below.
9ff0a3d
to
565383e
Compare
87f5a96
to
77922ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll wait until @talex5 has had a chance to review before merging.
It's hard to see what changes with sections being moved and edited at the same time. It seems like this is combining three things:
It would be helpful to separate these, as 2 needs more thinking about. For example, the section introducing The tracing section comes right after the fibers section so you can see visually what it looks like to run fibers concurrently. Ideally, we'd also illustrate the other examples, and readers can run the tracing tool to understand any code they write. As the tools aren't ready yet, it currently just shows how to dump the logs, which I agree isn't useful here, but this is just a place-holder while that's being written. |
77922ba
to
c11ed24
Compare
Thank you for the details, I really appreciate it because I know how annoying it can be when someone starts changing stuff without understanding why it is the way it is. I just reverted Now this PR is only about the Executor_pool and any obvious little fixes I ran into. Please give it another read and let me know what you think! Thank you |
c11ed24
to
909b55d
Compare
Most of this was merged in #650, so closing. |
Changes to the README:
"5.0"
with"5.1"
since Eio now requires OCaml 5.1Domainslib
andkcas
sections to their own files indoc/
Multicore Support
section to include, in order:Executor_pool
andDomain_manager.run
. Assumption: expert users will know when they need to directly create threads, no need to explain the rationale to them.Executor_pool
Domain_manager.run
I've moved the following sections to be afterSynchronization tools
:Multicore Support
(the user shoul learn about Promise, Mutexes, Streams, etc. first)Running processes
(same, and I expect this feature to see less frequent use than most modules that were placed ahead of it in the docs)Tracing
(this is a somewhat advanced feature, mostly geared towards debugging. I find it easier to not constantly mix "features" with "testing+debugging" in the docs)Testing with Mocks
(same as Tracing)Moved theMock Clocks
section fromTime
toTesting with Mocks
Worker Pool
example from theStreams
sectionPlease let me know if any of the above causes issues. Feel free to make changes directly on this branch.