Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call accept_fork's error handler on cancellation #520

Merged
merged 1 commit into from
May 18, 2023

Conversation

talex5
Copy link
Collaborator

@talex5 talex5 commented May 17, 2023

This typically happens when the server is shutting down and wants to stop all connection handlers. There is no need to have each connection fiber log this; they just need to stop.

@talex5 talex5 added the bug Something isn't working label May 17, 2023
This typically happens when the server is shutting down and wants to
stop all connection handlers. There is no need to have each connection
fiber log this; they just need to stop.
@talex5 talex5 merged commit 21c6a54 into ocaml-multicore:main May 18, 2023
@talex5 talex5 deleted the cancel-not-error branch May 18, 2023 13:25
@talex5 talex5 added this to the 0.10 milestone May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant