Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the stubs were previously incorrect as the
==
had higher precedence than the&
so it was always returningfalse
, I double checked with a small program:Which printed
false false
. You can see the apple C compiler complaining about it here: https://github.com/ocaml-multicore/eio/actions/runs/4870762082/jobs/8686910729.Afaict old programs using
eio_posix
shouldn't actually be impacted in terms of correctness as this was more of an optimisation to see if we need to wait for an FD to be readable/writeable.