-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module-prefix
optional argument to Ortac/QCheck-STM and Ortac/Dune
#280
Merged
n-osborne
merged 8 commits into
ocaml-gospel:main
from
n-osborne:module-prefix-cli-option
Dec 19, 2024
Merged
Add module-prefix
optional argument to Ortac/QCheck-STM and Ortac/Dune
#280
n-osborne
merged 8 commits into
ocaml-gospel:main
from
n-osborne:module-prefix-cli-option
Dec 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
465cd9f
to
75fdd10
Compare
CI is green, I'm confident that the code is correct. |
75fdd10
to
20004ec
Compare
jmid
reviewed
Dec 18, 2024
I had a look and the documentation LGTM (modulo a minor nit) 😃 👍 |
Update plugins/qcheck-stm/doc/index.mld Co-authored-by: Jan Midtgaard <mail@janmidtgaard.dk>
55ee122
to
6608429
Compare
Thanks! Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #268
This PR proposes to add a new optional argument to both Ortac/QCheck-STM and Ortac/Dune (the latter to use the former).
This new optional argument (
-m
or--module-prefix=
) allows to test a module that is exposed as part of a library.For example in:
You need to give
myModule
as the FILE argument, but it is not the right identifier for the module to open in the tests.With this patch, you can run:
And the corresponding optional argument has been added to Ortac/Dune.
Beware that this is not fit to test sub-modules. I plan to cook a sister PR for that before the soon-to-come next release.