-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sut as type argument or inside tuple #245
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f8bd525
to
26cc795
Compare
n-osborne
reviewed
Jul 23, 2024
26cc795
to
0c51735
Compare
This should raise an error but currently just produces incorrect code
0c51735
to
10a139b
Compare
3f39cbd
to
5063af2
Compare
n-osborne
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, thanks!
Just had some tiny remarks, but after that it is good to merge.
Co-authored-by: Nicolas Osborne <nicolas.osborne@tarides.com>
5063af2
to
5c719e3
Compare
n-osborne
added a commit
to n-osborne/opam-repository
that referenced
this pull request
Oct 8, 2024
This release brings a number of new features and improvements: - New features: + [ocaml#247](ocaml-gospel/ortac#247): Generated tests cover now functions with multiple SUT arguments + [ocaml#253](ocaml-gospel/ortac#253): Generated tests cover now functions returning SUT values + [ocaml#259](ocaml-gospel/ortac#259): Generated tests can be run in a separated process with a timeout - Improvements: + [ocaml#245](ocaml-gospel/ortac#245): Fix the analysis of function signature to explicitly not support SUTs inside another type + [ocaml#251](ocaml-gospel/ortac#251): Fix the display of the runnable scenario for value returned by a function that could have raised an exception
n-osborne
added a commit
to n-osborne/opam-repository
that referenced
this pull request
Oct 8, 2024
This release brings a number of new features and improvements: - New features: + [ocaml#247](ocaml-gospel/ortac#247): Generated tests cover now functions with multiple SUT arguments + [ocaml#253](ocaml-gospel/ortac#253): Generated tests cover now functions returning SUT values + [ocaml#259](ocaml-gospel/ortac#259): Generated tests can be run in a separated process with a timeout - Improvements: + [ocaml#245](ocaml-gospel/ortac#245): Fix the analysis of function signature to explicitly not support SUTs inside another type + [ocaml#251](ocaml-gospel/ortac#251): Fix the display of the runnable scenario for value returned by a function that could have raised an exception
n-osborne
added a commit
to n-osborne/opam-repository
that referenced
this pull request
Oct 10, 2024
This release brings a number of new features and improvements: - New features: + [ocaml#247](ocaml-gospel/ortac#247): Generated tests cover now functions with multiple SUT arguments + [ocaml#253](ocaml-gospel/ortac#253): Generated tests cover now functions returning SUT values + [ocaml#259](ocaml-gospel/ortac#259): Generated tests can be run in a separated process with a timeout - Improvements: + [ocaml#245](ocaml-gospel/ortac#245): Fix the analysis of function signature to explicitly not support SUTs inside another type + [ocaml#251](ocaml-gospel/ortac#251): Fix the display of the runnable scenario for value returned by a function that could have raised an exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug were we are not checking for the sut type being used as the instantiation of a type variable or inside a tuple, so for example
would type check correctly and create incorrect code.