Add an include option to qcheck-stm cli
#181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shym
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Good work! I’ve opened a PR with a couple of small suggestions.
I’m not sure where the ~docv in conv is used if you provide another one in info (I didn’t see it appear in the generated help) so, if that’s indeed overridden by the info one, we can go the standard combinators (as I could not find how to specify the docv with the combinators, I wonder whether the ~docv is really used, by the way).
Now I want to see it put into use for the dllist example! (I suppose that’s how you tested it anyway :-)
n-osborne
added a commit
to n-osborne/ortac
that referenced
this pull request
Nov 20, 2023
Suggestions for ocaml-gospel#181
n-osborne
force-pushed
the
include-option
branch
2 times, most recently
from
83d1a6b to
22ae643
Compare
n-osborne
force-pushed
the
include-option
branch
from
22ae643 to
0c7a466
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to add an include option to the
qcheck-stmcli. This will include the module passed as value of the option in the generated code. The idea is to allow the user to easily addSTM.tyextensions andSTM.Utils.pp*s without having to edit the generated file by hand.This PR does not move the configuration in the included module (the
init_sutexpression and thesuttype expression given by the user on the cli).