Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive benchmark #76

Merged
merged 2 commits into from
Jan 29, 2019
Merged

Revive benchmark #76

merged 2 commits into from
Jan 29, 2019

Conversation

Leonidas-from-XIV
Copy link
Member

Since we are not benchmarking against JSON Wheel anymore I took the liberty to remove the dependency and just port the previous benchmark into Core_bench which is very good at reporting performance numbers. Since this is not part of what people will need to use yojson or even run its tests I thought I'd prefer to just use an existing mature benchmark solution instead of rolling my own.

Maybe some more demanding benchmark data would be nice, and some more operations to test but for now I'll just await your input.

@Leonidas-from-XIV
Copy link
Member Author

For the record, current values on the machine I'm developing on:

Estimated testing time 20s (2 benchmarks x 10s). Change using -quota SECS.
┌──────────────┬──────────┬───────────┬──────────┬──────────┬────────────┐
│ Name         │ Time/Run │   mWd/Run │ mjWd/Run │ Prom/Run │ Percentage │
├──────────────┼──────────┼───────────┼──────────┼──────────┼────────────┤
│ JSON reading │  18.23us │ 1_167.02w │    2.23w │    2.23w │    100.00% │
│ JSON writing │  10.45us │   721.00w │  258.30w │    0.30w │     57.33% │
└──────────────┴──────────┴───────────┴──────────┴──────────┴────────────┘

Copy link
Collaborator

@NathanReb NathanReb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, this is a welcome change!

As you already said this is meant for developers so indeed using an external benchmark library isn't an issue at all here.

With time it might be interesting to add various type of input. Having a way to generate them so that we don't have to commit various and potentially large json files to the repo would probably be the way to go.

That's already great as it is and at least we have something to work with now!

@NathanReb NathanReb merged commit 56a61e9 into ocaml-community:master Jan 29, 2019
@Leonidas-from-XIV Leonidas-from-XIV deleted the revive-benchmark branch July 30, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants