Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are not benchmarking against JSON Wheel anymore I took the liberty to remove the dependency and just port the previous benchmark into
Core_bench
which is very good at reporting performance numbers. Since this is not part of what people will need to use yojson or even run its tests I thought I'd prefer to just use an existing mature benchmark solution instead of rolling my own.Maybe some more demanding benchmark data would be nice, and some more operations to test but for now I'll just await your input.