Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle booleans and numbers as environment variables #296

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Handle booleans and numbers as environment variables #296

merged 2 commits into from
Apr 4, 2024

Conversation

yjose
Copy link
Member

@yjose yjose commented Apr 4, 2024

What does this do?

Add example to handle numbers and boolean as env vars

Why did you do this?

#263

Who/what does this impact?

How did you test this?

Locally

@netlify Netlify
Copy link

netlify bot commented Apr 4, 2024 •
edited
Loading

✅ Deploy Preview for obytes-starter ready!

Name Link
🔨 Latest commit 525e4aa
🔍 Latest deploy log https://app.netlify.com/sites/obytes-starter/deploys/660e11496338f4000831952a
😎 Deploy Preview https://deploy-preview-296--obytes-starter.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024 •
edited
Loading

💯 Test Coverage

Lines Statements Branches Functions
Coverage: 38%
 37.75% (182/482) 33.48% (73/218) 24.73% (46/186)

😎 Tests Results

Tests Skipped Failures Errors Time
40 0 💤 0 ❌ 0 🔥 26.994s ⏱️
👀 Tests Details • (38%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files37.7533.4824.7338.86 
report-only-changed-files is enabled. No files were changed in this commit :)

@yjose yjose changed the title Handle boolean and numbers as env vars Handle booleans and numbers as environment variables Apr 4, 2024
@yjose yjose requested a review from ElenaBitire April 4, 2024 02:35
ElenaBitire
ElenaBitire approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@ElenaBitire ElenaBitire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yjose yjose merged commit fb23fba into master Apr 4, 2024
10 checks passed
@yjose yjose deleted the feat-allow-number-bool-env-vars branch September 10, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElenaBitire ElenaBitire ElenaBitire approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yjose @ElenaBitire