Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: Add option to lock binding to IPv4 #559

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

tt2468
Copy link
Member

@tt2468 tt2468 commented Jul 10, 2020

Description

This adds an option to force WebsocketPP to use the default IPv4 interface to bind to.

Motivation and Context

WebsocketPP defaults to binding to an IPv6 interface. Since IPv6 is broken on so many networks, there is a need to give users the option to force disable it. This change does not affect the default behavior of obs-websocket.

Fixes #531

How Has This Been Tested?

Tested OS(s): Ubuntu 20.04

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (modification to a current event/request which adds functionality)

Checklist:

  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

WebsocketPP defaults to binding to an IPv6 interface. Since IPv6
is broken on so many networks, this adds an option to force WebsocketPP
to use the default IPv4 interface to bind to.
@tt2468 tt2468 added this to the 4.9 milestone Jul 10, 2020
@Palakis Palakis self-requested a review July 10, 2020 05:43
@Palakis Palakis merged commit bcd16d7 into 4.x-current Sep 15, 2020
@tt2468 tt2468 deleted the enhancement/ipv4-option branch October 4, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Websocket only listening on localhost ipv6 in Linux
2 participants