Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Reenable building with captions on MacOS #546

Merged
merged 1 commit into from
Jul 1, 2020
Merged

[Bug Fix] Reenable building with captions on MacOS #546

merged 1 commit into from
Jul 1, 2020

Conversation

curtgrimes
Copy link

This reverts #477. OBS on MacOS supports closed caption encoding. The Windows-only dependencies here are only related to audio capture, not closed caption encoding.

OBS Studio 25.0.8 and latest version of obs-websocket 4.x built with BUILD_CAPTIONS=true receiving an event originating from obs-websocket-js:

20:14:31.677: [obs-websocket] Request >> '{"text":"hello world! Mon Jun 29 2020 20:14:31 GMT-0500 (Central Daylight Time)","request-type":"SendCaptions","message-id":"39"}'
20:14:31.677: [obs-websocket] Response << '{
20:14:31.677:     "message-id": "39",
20:14:31.677:     "status": "ok"
20:14:31.677: }'

Closed captions appearing in Twitch stream:
Screen Shot 2020-06-29 at 8 13 57 PM

OBS on MacOS supports closed caption encoding. The Windows-only dependencies [here](https://github.com/obsproject/obs-studio/blob/master/UI/frontend-plugins/frontend-tools/CMakeLists.txt#L73) are only related to audio capture, not closed caption encoding.
@tt2468
Copy link
Member

tt2468 commented Jun 30, 2020

If captions are already included regardless of the CMake file, then wouldn't it also support linux too?

@curtgrimes
Copy link
Author

I don't have an environment where I can test Linux support at the moment, but on the MacOS side it definitely appears to work.

@tt2468
Copy link
Member

tt2468 commented Jul 1, 2020

Tested myself on ubuntu, works great. Merging this since there is nothing to change for Ubuntu.

@tt2468 tt2468 merged commit a4279d0 into obsproject:4.x-current Jul 1, 2020
@curtgrimes
Copy link
Author

curtgrimes commented Jul 2, 2020

@tt2468 Thank you! Any chances for a point release? I'm looking to use this in an app soon and it will simplify instructions if I don't need to explain to users how to build this on their own if they're on MacOS.

@tt2468
Copy link
Member

tt2468 commented Jul 2, 2020

You can download your pr's macos artifact here, which should include an installer https://dev.azure.com/Palakis/2687c5e1-1f5c-4326-8080-85cbdf4f4033/_apis/build/builds/1288/artifacts?artifactName=macos_build&api-version=5.1&%24format=zip

@arisprung
Copy link

Is this related to the issue I opened here ? #617

If so, How do I fix this?
Thx!

@Palakis
Copy link
Contributor

Palakis commented Nov 22, 2020

@arisprung Yes it is!

@Palakis
Copy link
Contributor

Palakis commented Nov 22, 2020

@arisprung
Copy link

Thx!
What do I need to install? The macos_build is not clickable...
Screen Shot 2020-11-22 at 16 49 36

@tt2468
Copy link
Member

tt2468 commented Nov 22, 2020

There is a download arrow on the right side of the row if you hover over it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants