Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Increase MAX_CRASH_REPORT_SIZE to 200 KB #11869

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WizardCM
Copy link
Member

Description

With CEF and NDI, logs can exceed 150KB, cutting off symbol addresses. Bump up the maximum crash report size to make that less likely.

Motivation and Context

One method of fixing #11842. Could raise it higher, but there's a reason why the limit exists.

How Has This Been Tested?

Make OBS crash on Windows.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

With CEF and NDI, logs can exceed 150KB, cutting off symbol addresses.
@WizardCM WizardCM added Bug Fix Non-breaking change which fixes an issue Windows Affects Windows labels Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue Windows Affects Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants