mac-capture: Don't read channels for disconnected audio device #11477
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When getting CoreAudio properties for an audio device source on macOS, make sure the source is active and initialized before trying to read channel information.
Motivation and Context
If we had an audio device source on macOS, and that device was subsequently disconnected from the machine, OBS would uninitialize the source, freeing the data associated with the audio channels. libobs however would still see the channel layout information, and when trying to get the source properties, would read from the previously freed channel data.
Fixes #11432, https://obsproject.com/forum/threads/crash-on-macos.181702/
Some other issues still abound in this code, and it is somewhat due for improvement, but for now, important to fix what is actually crashing.
How Has This Been Tested?
Tested locally on macOS 15.1; first reproduced the crash per the instructions in #11432. With the patch applied, the crash no longer occurs.
Types of changes
Checklist: