obs-qsv11: Remove old MSDK 1.6 code #11473
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RytoEX
added
the
Code Cleanup
RytoEX
force-pushed
the
remove-msdk-1-6-from-qsv
branch
2 times, most recently
from
c1e531a
to
e2414da
Compare
|
As a note, I commented out one or two lines of the frame type checking code in the first commit and then moved and uncommented it in the second commit. This is mostly to try to keep the original diff (the first commit) sane and readable, but both commits can be squashed if that makes more sense. |
kkartaltepe
reviewed
Nov 2, 2024
kkartaltepe
approved these changes
Nov 2, 2024
The old MSDK 1.6 code paths were for older devices which we no longer support. Typically, version 1.0 is reported when QSV fails to initialize. The lowest version that should be supported is 1.35, so we should not need code that covers versions 1.0 to 1.6.
The code that checked frame types was used by both the MSDK < 1.7 code and by the debug code afterward that was conditionally enabled with a preprocessor check. Since the frame type checks are no longer used by user code, move it to the debug/dev code.
RytoEX
force-pushed
the
remove-msdk-1-6-from-qsv
branch
from
e2414da
to
13525a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The old MSDK 1.6 code paths were for older devices which we no longer support. Typically, version 1.0 is reported when QSV fails to initialize. The lowest version that should be supported is 1.35, so we should not need code that covers versions 1.0 to 1.6.
Motivation and Context
Don't want dead code.
How Has This Been Tested?
Tested locally on Windows 11 with an Arc A770M.
Types of changes
Checklist: