Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mac-virtualcam: Update NotInstalled error text for macOS 15 #11006

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

jcm93
Copy link
Contributor

@jcm93 jcm93 commented Jul 19, 2024

Description

Updates the error message for an uninstalled/not-yet-approved camera system extension on macOS 15.

Motivation and Context

Apple moved where the user approves system extensions away from "Privacy & Security" to "General -> Login Items & Extensions". Don't want to provide outdated/incorrect directions. Beta users have already arrived confused in support about the old message.

How Has This Been Tested?

Tested in an offline branch with a custom signing configuration to allow for the installation of system extensions, then relevant changes manually copied to this branch but not technically tested. Should be double checked.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@jcm93 jcm93 force-pushed the macos15-extension branch 2 times, most recently from d34401f to 76fcb21 Compare July 19, 2024 06:11
@RytoEX RytoEX requested review from PatTheMav and gxalpha July 20, 2024 00:00
@RytoEX RytoEX added the Bug Fix Non-breaking change which fixes an issue label Jul 20, 2024
@RytoEX RytoEX added this to the OBS Studio 31 milestone Jul 20, 2024
Copy link
Member

@PatTheMav PatTheMav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine.

On the whole I'd rather present a dialog box with a specific button that will take you to the corresponding settings dialog instead of using a breadcrumb string which is not particularly easy to parse.

@RytoEX RytoEX self-assigned this Jul 29, 2024
@RytoEX RytoEX merged commit ff2fa24 into obsproject:master Jul 31, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants