Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libobs-opengl: Disable NV12/P010 on Windows #11002

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

kkartaltepe
Copy link
Collaborator

Description

These formats are used for texture encoding but the OpenGL texture encoding pipeline is not supported on Windows. This can also cause failure to initialize on Windows so it's better to disable the formats.

Motivation and Context

Some people who forced the OpenGL backend had failures.

How Has This Been Tested?

Hopefully someone on windows can test this.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

These formats are used for texture encoding but the OpenGL texture
encoding pipeline is not supported on Windows. This can also cause
failure to initialize on Windows so it's better to disable the formats.
@derrod
Copy link
Member

derrod commented Jul 18, 2024

Unfortunately still fails on Windows.

Copy link
Member

@derrod derrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind it's fine, Visual Studio was just being difficult.

@RytoEX RytoEX changed the title libobs-opengl: disable nv12/p010 on Windows libobs-opengl: Disable nv12/p010 on Windows Jul 18, 2024
@RytoEX RytoEX changed the title libobs-opengl: Disable nv12/p010 on Windows libobs-opengl: Disable NV12/P010 on Windows Jul 18, 2024
@RytoEX RytoEX self-assigned this Jul 18, 2024
@RytoEX RytoEX added the Bug Fix Non-breaking change which fixes an issue label Jul 18, 2024
@RytoEX RytoEX added this to the OBS Studio 30.2 milestone Jul 18, 2024
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RytoEX RytoEX merged commit 7912d06 into obsproject:master Jul 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants