Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add architecture support to add_obs_plugin and allow QSV only on x86_64 #11000

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Add architecture support to add_obs_plugin and allow QSV only on x86_64 #11000

merged 2 commits into from
Jul 29, 2024

Conversation

tytan652
Copy link
Collaborator

@tytan652 tytan652 commented Jul 17, 2024 •
edited
Loading

Description

Add architecture support to add_obs_plugin and allow QSV only on x86_64

Motivation and Context

Intel stack is only completely buildable on x86_64 architectures.

How Has This Been Tested?

I need CI to check Windows.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@tytan652 tytan652 requested a review from PatTheMav July 17, 2024 10:27
@tytan652 tytan652 requested a review from PatTheMav July 17, 2024 10:56
@tytan652 tytan652 force-pushed the obs_plugin_arch+qsv branch 2 times, most recently from d989317 to 1390e2a Compare July 17, 2024 11:04
@tytan652 tytan652 requested a review from PatTheMav July 17, 2024 11:05
@tytan652 tytan652 force-pushed the obs_plugin_arch+qsv branch 2 times, most recently from 9611917 to 8fb4aed Compare July 17, 2024 11:32
PatTheMav
PatTheMav reviewed Jul 17, 2024
View reviewed changes
cmake/common/helpers_common.cmake Show resolved Hide resolved
cmake/common/helpers_common.cmake Outdated Show resolved Hide resolved
@tytan652
cmake: Add architecture support to add_obs_plugin
3225e93 
Also add formatting support to the function
@tytan652
plugins: Enable QSV only on x86_64 architecture
89bc768 
Intel stack is only completely buildable on x86_64 architectures.
PatTheMav
PatTheMav approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@PatTheMav PatTheMav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, if CI shows that QSV was correctly included for Windows and Linux (and other plugins without specified architectures were added in all cases), should be good to go.

@WizardCM WizardCM added the Enhancement Improvement to existing functionality label Jul 20, 2024
@RytoEX RytoEX self-assigned this Jul 24, 2024
RytoEX
RytoEX approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good at a glance. Will target for 31.

@RytoEX RytoEX added this to the OBS Studio 31 milestone Jul 24, 2024
@RytoEX RytoEX merged commit 7d578c5 into obsproject:master Jul 29, 2024
15 checks passed
@tytan652 tytan652 deleted the obs_plugin_arch+qsv branch July 30, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RytoEX RytoEX RytoEX approved these changes

@PatTheMav PatTheMav PatTheMav approved these changes

Assignees

@RytoEX RytoEX

Labels
Enhancement Improvement to existing functionality
Projects
None yet
Milestone
OBS Studio 31
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tytan652 @RytoEX @PatTheMav @WizardCM