-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add architecture support to add_obs_plugin and allow QSV only on x86_64 #11000
Conversation
d989317
to
1390e2a
Compare
9611917
to
8fb4aed
Compare
Also add formatting support to the function
Intel stack is only completely buildable on x86_64 architectures.
8fb4aed
to
89bc768
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, if CI shows that QSV was correctly included for Windows and Linux (and other plugins without specified architectures were added in all cases), should be good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good at a glance. Will target for 31.
Description
Add architecture support to add_obs_plugin and allow QSV only on x86_64
Motivation and Context
Intel stack is only completely buildable on x86_64 architectures.
How Has This Been Tested?
I need CI to check Windows.
Types of changes
Checklist: