UI: Don't create default desktop audio source on macOS 13+ #10992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WizardCM
added
Enhancement
Lain-B
approved these changes
Jul 20, 2024
There was a problem hiding this comment.
I suppose this is fine. You okay with it @Warchamp7?
Might be good to change the commit email though.
jcm93
force-pushed
the
disable-desktop-audio-macos
branch
from
5420cce
to
74b3e40
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the default device-based "Desktop Audio" source created on first run if the user is on macOS 13+.
Motivation and Context
Since adding macOS Screen Capture in macOS 13, the recommended way to capture audio on macOS is via that source (or alternately, the macOS Audio Capture source for strictly audio-only sources). The device-based audio source idiom is only relevant for older versions of macOS, or for some specialized workflows that require advanced audio routing via programs like Blackhole, VB-Cable, et. al.
The creation of this device-based source by default on new macOS 13+ systems very often leads to new user confusion. It doesn't provide any audio, and users often think that they need to configure it to get desktop audio, which can actually point them away from the newer, easier-to-use audio capture methods.
On top of being nonfunctional, the source also just takes up space in the audio mixer until the user disables it.
How Has This Been Tested?
Tested on macOS 15. On a fresh startup of OBS, the Desktop Audio device in Settings is now set to "Disabled," with only the Mic/Aux source configured in the audio mixer.
Types of changes
Checklist: