Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Set CFBundleDisplayName for camera extension #10982

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

gxalpha
Copy link
Member

@gxalpha gxalpha commented Jul 13, 2024

Description

macOS 15 shows this in the settings (or at least I think it's only from 15, haven't seen it earlier).
This is in System Settings -> Common [or whatever it's named in English] -> Login Objects and Extensions [or similar] -> Extensions.

Before/After (German, but the important part should be obvious):

Bildschirmfoto 2024-07-13 um 23 55 24 Bildschirmfoto 2024-07-14 um 00 20 54

Motivation and Context

Noticed this randomly when browsing through the login items settings.
If we don't set the display name macOS will fall back on the identifier which isn't great for users.

How Has This Been Tested?

macOS 15, installed vcam and saw the new name in system settings.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

macOS shows this in the settings so we should set it, otherwise it will
fall back on the identifier which isn't great for users.
@gxalpha gxalpha added Bug Fix Non-breaking change which fixes an issue Enhancement Improvement to existing functionality macOS Affects macOS labels Jul 13, 2024
@gxalpha gxalpha requested a review from PatTheMav July 13, 2024 22:29
@RytoEX RytoEX added this to the OBS Studio 31 milestone Jul 13, 2024
Copy link
Member

@PatTheMav PatTheMav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine.

@RytoEX RytoEX self-assigned this Jul 29, 2024
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RytoEX RytoEX merged commit 4bbf8df into obsproject:master Jul 30, 2024
15 checks passed
@gxalpha gxalpha deleted the vcam-displayname branch July 30, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue Enhancement Improvement to existing functionality macOS Affects macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants