UI: Media source always played if close file when inactive is checked

[Sugam-Chand-M]

Description

Even when the "Close when Inactive" property is checked and the source is inactive, the media was being played.
Issue - [ #10676 ]

Motivation and Context

This PR aims at resolving the issue by pausing the media play when the source is inactive and the "Close when Inactive" property is checked.
Issue - [ #10676 ]

How Has This Been Tested?

Tested manually in Windows 11.
Added a video drive link - Video Link of the fix working

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

• My code has been run through clang-format.
• I have read the contributing document.
• My code is not on the master branch.
• The code has been tested.
• All commit messages are properly formatted and commits squashed where appropriate.
• I have included updates to all appropriate documentation.

[SuslikV]

I think, the fix is incorrect. The option meaning changed in this PR. This may lead to confusion in future when new programmers will read the code.

The option to "close file" designed to free the file handler. Thus, the file can be in use and not exclusively by OBS.
Maybe the tip to the option is not clear enough and could be reworded (don't know is it really worth so much attention or not):

obs-studio/plugins/obs-ffmpeg/data/locale/en-US.ini

Lines 81 to 82 in 7912d06

	CloseFileWhenInactive="Close file when inactive"
	CloseFileWhenInactive.ToolTip="Closes the file when the source is not being displayed on the stream or\nrecording. This allows the file to be changed when the source isn't active,\nbut there may be some startup delay when the source reactivates."

here the phrase "This allows the file to be changed..." has wider meaning: the file can be renamed, old file can be deleted and new file can be created with the same name, whole content of the media file can be modified (edited) when this option is checked.

In my opinion, the "Pause of playback" and "File close" is completely different actions. Current OBS logic states that media continues its playback even when the media source is not in the current scene ("not active" in terms of OBS - not shown in the stream/recording).

Yes, logically the "close of the file" is exclusive to the "not active" state of the source, but defaults of OBS is to "always playback" the source (and never stop playback until media ends or loop is forced).

The proposed changes can be considered as a fix, but previously such huge changes in logic were implemented as versioned variants of the sources (to keep behavior unchanged for scenes that already created by users). Maybe additional checkbox to "force the pause when media is not active" - is a better option here? For example, similar option exist for VLC Source of OBS.

One more thing... (includes 3 questions)
"not active" in terms of OBS - should it include playback of the media or shouldn't?

1. In other words, if media playbacks (in background, in other scene, not appears in the stream/recording) - is this still "active" source or not in your opinion?
2. "Paused" media - is this "active" source or not?
3. "Stopped" media - is this "active" source or not?

[Sugam-Chand-M]

Hi @SuslikV

Sorry for the very delayed response

"Close the file when inactive" option is for not displaying the sources when it is inactive and not to be deleted from the source.
When the product was designed and coded, I believe they have considered the scenario where if the user wants to temporarily disable the source which shouldn't be visible so they have included this option.

For the questions,

1. Ideally when the source is inactive, the media shouldn't not be played or should be paused and played from the position when it becomes active again
2. It can be either, active or inactive, its like inactive => paused but vice versa is not true
3. Same as the answer for 2nd