Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rtmp-services: Update MasterStream.iR ingest #10978

Closed
wants to merge 0 commits into from

Conversation

masterking32
Copy link
Contributor

Description

Updating MasterStream.iR to OBS Studio's Ingest List

How Has This Been Tested?

  • JSON validation: Ensured that the JSON files were well-formed and adhered to the required format for OBS-Studio's ingest list.
  • Copy JSON files to %APPDATA%\obs-studio\plugin_config\rtmp-services: Manually copy the JSON files to the appropriate location where OBS-Studio reads ingest settings.
  • Checked settings: Verified that MasterStream.iR appears in the updated ingest list within OBS-Studio's settings.
  • Connection testing: Attempted to connect to the servers provided by MasterStream.iR to ensure successful streaming functionality.
  • According to Service Submission Guidelines

Types of changes

  • Updating feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits are squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX RytoEX self-assigned this Jul 30, 2024
@RytoEX RytoEX added the Services These are modifications to the Service list and are not tied to the release schedule label Jul 30, 2024
@RytoEX RytoEX closed this Jul 30, 2024
@RytoEX
Copy link
Member

RytoEX commented Jul 30, 2024

My apologies, but you will have to resubmit this PR. GitHub automatically closed the PR due to a mistake on my part trying to force push an update. As the PR is closed, I can no longer force push fixes to the branch. The main thing that needs to be fixed is the package version (this had changed in the interim).

However, please do not submit PRs from your master branch. It makes it more difficult to manage situations like this. Please create a separate branch in your repo and use that to submit the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Services These are modifications to the Service list and are not tied to the release schedule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants