-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Create OBS Studio folder for default recording location #10974
base: master
Are you sure you want to change the base?
Conversation
if (!MakeRecordingDir()) | ||
throw "Failed to create recording directory"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be unnecessary as the directory is created on demand when a recording is started. OBS should not create an empty folder in the user's video folder just from being run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't an app storage location though, this is the user's data folders. Well-designed apps should respect a user's folder layout and not create empty files and directories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have some sort of guidance or documentation from Microsoft about that?
I have multiple applications on my system that have created folders for themselves in the Videos library location
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just good behavior, just because other apps are shitty doesn't mean we should also be shitty. There's plenty of evidence of of users who desire such behavior from their apps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One's shitty behaviour is another's expected behaviour though. And by that token I'd rather have an application create files in its own managed subdirectory than mess up the root of a data storage location.
I do agree that the directory should be created upon first use though. I don't remember Shadowplay creating directories for recordings or highlights until I actually triggered either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I concur with first use, as a user who does not enjoy all the random empty folders I have no intention of using.
60f7a82
to
2336f81
Compare
2336f81
to
1348efb
Compare
return getenv("HOME"); | ||
if (moviesDirectory) { | ||
const string videoSavePath = | ||
[moviesDirectory URLByAppendingPathComponent:@"OBS-Studio" isDirectory:YES].path.fileSystemRepresentation; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[moviesDirectory URLByAppendingPathComponent:@"OBS-Studio" isDirectory:YES].path.fileSystemRepresentation; | |
[moviesDirectory URLByAppendingPathComponent:@"OBS Studio" isDirectory:YES].path.fileSystemRepresentation; |
Shouldn't this just be "OBS Studio"? Spaces are fine to pass as a component to this function, and I'm not aware of any issues with spaces in folder names for OBS.
Description
This updates the default directory for recordings to be a newly created
OBS Studio
folder inside the default directory%UserProfile%/Videos/OBS Studio
on Windows/home/<User>/OBS Studio
on Linux (?)/Users/<User>/Movies/OBS Studio
on macOS (?)Code for Linux and mac will need review and suggestions because I am completely guessing there and it will almost certainly not compile.
Motivation and Context
Better organization for users
How Has This Been Tested?
Tested on Windows.
Ensured the directory is created during initial startup and properly set for new Profiles.
Types of changes
Checklist: