Updated text-functionality.c #10956
Closed
Updated text-functionality.c #10956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uppdated load_text_from_file function
derrod
suggested changes
Jul 8, 2024
|
If you are interested in working on this please read the previous discussions on what is actually required to fix the issue, #7595 (comment) |
Can you elaborate the issue to me |
norihiro
reviewed
Jul 13, 2024
Comment on lines
+421
to
+425
| srcdata->text = bzalloc(filesize); | ||
| bytes_read = fread(srcdata->text, filesize - 2, 1, tmp_file); | ||
|
|
||
| // Ensure null-termination of the string | ||
| srcdata->text[(filesize - 2) / sizeof(wchar_t)] = L'\0'; |
There was a problem hiding this comment.
bzalloc initialize the allocated region with 0.
Why was this line added?
|
Thanks for the interest in the issue, but im going to close this since I have gone ahead to implement the fix I was intending. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uppdated load_text_from_file function
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: