libobs: Add obs_encoder_get_group()
#10952
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows getting of the current encoder group of an encoder. Needed in my case for enabling some performance optimizations in an encoder plugin.
palana
reviewed
Jul 16, 2024
Comment on lines
+2049
to
+2054
| obs_encoder_group_t *obs_encoder_get_group(obs_encoder_t *encoder) | ||
| { | ||
| return obs_encoder_valid(encoder, "obs_encoder_get_group") | ||
| ? encoder->encoder_group | ||
| : NULL; | ||
| } |
There was a problem hiding this comment.
given the intricacies around the lifetime of groups I'd suggest going with a design that doesn't expose the pointer to code that doesn't own the group, e.g.
bool obs_encoder_is_grouped_with(obs_encoder_t *encoder, obs_encoder_t *other_encoder)or maybe add a comment to the function along the lines of
this pointer is only safe to use before encoders have been started or while encoders are active; the pointer might get invalidated as soon as encoders become inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows getting of the current encoder group of an encoder. Not useful for too much on its own, but allows encoder implementations to know if they are in a group or not.
Motivation and Context
Needed in my case for enabling some performance optimizations in an encoder plugin. I can rely on encoder groups in my plugin to create a shared scaler object for encoders within the group, rather than always one scaler per encoder always. This gives me a >30% efficiency boost in my scaler utilization.
How Has This Been Tested?
Compiles on Ubuntu 22.04
Types of changes
Checklist: