Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc patches #11

Merged
merged 3 commits into from
Jul 27, 2018
Merged

Doc patches #11

merged 3 commits into from
Jul 27, 2018

Conversation

fredcy
Copy link
Contributor

@fredcy fredcy commented Jul 17, 2018

I suggest these changes to address issues that I ran into while installing your software.

README.md Outdated
@@ -312,6 +314,9 @@ before your prompt -- use pip to install the `ledgerblue`
This will install the Ledger Python packages into the virtualenv; they will be
available only in a shell where the virtualenv has been activated.

Note: We are installing this python package named "ledgerblue" even though we are working with Ledger Nano S hardware.
Do not skip this step even though you are not usign Ledger Blue hardware.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo usign

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it was late. Sigh.

@jhartzell42 jhartzell42 merged commit b955331 into obsidiansystems:master Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants