Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch exception on edge case where downloads table is not present #167

Merged
merged 1 commit into from
Mar 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions pyhindsight/browsers/chrome.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import hashlib
import math
import os
import sqlite3
import sys
import errno
import datetime
Expand Down Expand Up @@ -484,8 +485,13 @@ def get_downloads(self, path, database, version, row_type):
return
cursor = conn.cursor()

# Use highest compatible version SQL to select download data
cursor.execute(query[compatible_version])
# Use the highest compatible version SQL to select download data
try:
cursor.execute(query[compatible_version])
except sqlite3.OperationalError as e:
log.warning(f' - Exception while executing query; {e}')
self.artifacts_counts[database + '_downloads'] = 'Failed'
return

for row in cursor:
try:
Expand Down