Avoid nil pointer access due to empty chunk returned from gosnowflake.buildFirstArrowChunk #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FirstArrowChunk Modify gosnowflake.buildFirstArrowChunk to return an error and pass it back up the call stack. The following three tests fail additionally compared to upstream, which is expected (see 'Maintaining the gosnowflake fork'): > TestPutGetFile > TestPutGetStream > TestPutGetGcsDownscopedCredential
till-kolditz
force-pushed
the
avoid_npe
branch
from
177b067 to
474169f
Compare
georgios-observeinc
approved these changes
Dec 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extended function
buildFirstArrowChunkto also return an error, which when not nil is immediately returned by*snowflakeChunkDownloader.start()and*snowflakeChunkDownloader.startArrowBatches().Checklist
make fmtto fix inconsistent formatsmake lintto get lint errors and fix all of them