Precompute scaled channels. #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I gave it a go as well and I think it's going to work well. We'll still need to pass the scales for some marks (axes, for example); I'm not sure we need to pass the unscaled channels, but it might be interesting for some user-defined marks to have access to the raw channel. |
mbostock
commented
Mar 28, 2021
src/plot.js
Outdated
Comment on lines
133
to
137
| return Object.fromEntries(Object.entries(scales).map(([name, {scale}]) => [name, scale])); | ||
| return Object.fromEntries(Object.entries(scales).map(([name, scale]) => [name, nullsafe(scale)])); | ||
| } | ||
|
|
||
| // TODO https://github.com/d3/d3-scale/pull/241/files | ||
| function nullsafe({type, scale}) { | ||
| return type === "quantitative" | ||
| ? Object.assign(x => x === null ? NaN : scale(x), scale) | ||
| : scale; |
There was a problem hiding this comment.
If we land d3/d3-scale#241 we can revert this part.
This was referenced Mar 29, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hack (I don’t think we’d want to use a getter for this — I’m thinking instead there would need to be a phase after the scales are constructed where Plot computes the scaled channels), but it works for the letterFrequencyBar and penguinSex examples.
Also, mark rendering ends up being simpler to boot.
Fixes #52.