Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An x-only plot should be taller if there’s an x-facet. #269

Closed
wants to merge 2 commits into from
Closed

An x-only plot should be taller if there’s an x-facet. #269

wants to merge 2 commits into from

Conversation

Fil
Copy link
Contributor

@Fil Fil commented Mar 24, 2021 •
edited
Loading

fixes #125
fixes #52
fixes #45

@Fil Fil requested a review from mbostock March 24, 2021 11:25
@Fil
compute the scaled coordinates of bars (and cell) before filtering, a…
6dbe377 
…llowing NaN, null and undefined as (ordinal) classes

fixes #52
fixes #45
@Fil
Copy link
Contributor Author

Fil commented Mar 24, 2021

(Sorry I was on the wrong branch.)

@Fil Fil closed this Mar 24, 2021
@Fil Fil deleted the x-only-125 branch March 24, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbostock mbostock Awaiting requested review from mbostock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Fil